Update contributing guide to add additional instructions #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Tsao <[email protected]>
kim-tsao
requested review from
elsony
and removed request for
rm3l and
michael-valdron
maysunfaisal
approved these changes
Sep 19, 2023
elsony
reviewed
Sep 19, 2023
CONTRIBUTING.md
Outdated
|
|
||
| ### Contributing | ||
| 1. Open an issue in the [devfile/api](https://github.com/devfile/api) repo to track adding a new stack or sample | ||
| 2. Avoid using container images (check for references in the Devfile and Dockerfile) from registries (like DockerHub) that impose rate limiting. |
There was a problem hiding this comment.
Can we provide more guidance, e.g. using a mirror on quay.io, to work around the problem
Signed-off-by: Kim Tsao <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsony, kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This is part of the proposed Devfile Lifecycle doc. Addressing review comments for stack providers in doc https://docs.google.com/document/d/1Syr8SZyLoVGwvZTyjHnEFm9CQ3xpQ3zBgw-PLldxsNY/edit:
Which issue(s) this PR fixes:
Link to github issue(s)
devfile/api#1066
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: