Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-maven] Use LTS JDK 17 image #167

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Mar 17, 2023

What does this PR do?:

This updates the container image to registry.access.redhat.com/ubi9/openjdk-17, to keep up with the latest JDK LTS, security-wise.

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
    Tested with odo.

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

Hi @rm3l. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel
Copy link
Member

kadel commented Mar 31, 2023

Similarly as in #169 I think it might be better to keep the old versions

@rm3l rm3l force-pushed the java-maven_bump_jdk_to_17 branch from 62fb3cb to 8911fd8 Compare April 6, 2023 21:15
@rm3l
Copy link
Member Author

rm3l commented Apr 6, 2023

Similarly as in #169 I think it might be better to keep the old versions

Done. I hesitated to do so in the beginning mainly because of the maintenance overhead, but yes, it makes sense to keep the old version. The default version of the stack still points to the old 1.2.0, but let me know if you think this should be changed.

@kim-tsao
Copy link
Collaborator

kim-tsao commented May 3, 2023

/ok-to-test

@kim-tsao
Copy link
Collaborator

/retest

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Oct 18, 2023
rm3l added 3 commits October 18, 2023 18:08
1.3.0 is the most up-to-date version using Devfile 2.1.0 schema,
for backward compatibility with current samples.
We are purposely not using the most up-date version on 2.2.0 schema,
as this would reportedly break current samples.

See [1] for more context.

[1] devfile#169 (comment)

Signed-off-by: Armel Soro <[email protected]>
@rm3l rm3l force-pushed the java-maven_bump_jdk_to_17 branch from 7864fa4 to 0b83295 Compare October 18, 2023 16:12
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Oct 18, 2023
@rm3l
Copy link
Member Author

rm3l commented Oct 18, 2023

Same discussion as in #169 applies here, about changing the default version.

As agreed with the rest of the team, I'm switching the default version of this stack to 1.3.0 (the one still on Devfile 2.1.0, but with a more recent JDK 17), for backward compatibility with the samples.

@rm3l rm3l requested a review from kadel October 18, 2023 16:12
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Oct 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l rm3l merged commit 732131f into devfile:main Oct 20, 2023
6 checks passed
@rm3l rm3l deleted the java-maven_bump_jdk_to_17 branch October 20, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants