-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java-maven] Use LTS JDK 17 image #167
Conversation
Hi @rm3l. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9140864
to
e318ad2
Compare
e318ad2
to
62fb3cb
Compare
Similarly as in #169 I think it might be better to keep the old versions |
62fb3cb
to
8911fd8
Compare
Done. I hesitated to do so in the beginning mainly because of the maintenance overhead, but yes, it makes sense to keep the old version. The default version of the stack still points to the old 1.2.0, but let me know if you think this should be changed. |
/ok-to-test |
/retest |
8911fd8
to
7864fa4
Compare
Signed-off-by: Armel Soro <[email protected]>
Signed-off-by: Armel Soro <[email protected]>
1.3.0 is the most up-to-date version using Devfile 2.1.0 schema, for backward compatibility with current samples. We are purposely not using the most up-date version on 2.2.0 schema, as this would reportedly break current samples. See [1] for more context. [1] devfile#169 (comment) Signed-off-by: Armel Soro <[email protected]>
7864fa4
to
0b83295
Compare
Same discussion as in #169 applies here, about changing the default version. As agreed with the rest of the team, I'm switching the default version of this stack to 1.3.0 (the one still on Devfile 2.1.0, but with a more recent JDK 17), for backward compatibility with the samples. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
This updates the container image to
registry.access.redhat.com/ubi9/openjdk-17
, to keep up with the latest JDK LTS, security-wise.Which issue(s) this PR fixes:
—
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tested with
odo
.How to test changes / Special notes to the reviewer: