-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devtools] Registry-support Release Automation Script #260
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question I have (might not be 100% related to this PR), is if we should include the document of the release process too here. IMO it feels more complete to have the documentation with the automation together.
In the README you mean? I linked it in the PR so far |
Yeah, in the main README.md I'd expect a link to a release process and there we can mention the automation script too. More or less to include the information from the link you provide in the PR. For instance, the |
Signed-off-by: Jordan Dubrick <[email protected]>
@thepetk I included in my last commit a portion linking to the process doc, I am planning on updating the google doc with script usage after this PR is merged so I can accommodate any changes made |
Maybe we could also think to move the google doc to the repo? WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Do we do that in other devfile repos? I am on the fence since the process requires write access to the repo so it only is relevant to our team |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 41.78% 41.78%
=======================================
Files 9 9
Lines 3269 3269
=======================================
Hits 1366 1366
Misses 1697 1697
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have published a process or key points of the process for several repos: IMO is ok to add some information about the release process and remove the link to the google doc. |
@thepetk I'll port over the process doc to a |
I think we can also address this in a different PR if this one is urgent! |
I can contain it as part of this :) no worries |
Signed-off-by: Jordan Dubrick <[email protected]>
@thepetk I ported the google doc release process to a markdown file, I made some tweaks to it to accommodate comments left on the google doc! Do you mind doing a re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdubrick looks good to me. I don't know if you'd like to merge release/PROCESS.md and release/README.md in a single file called release/RELEASE.md similarly to what we have in devfile/api
Signed-off-by: Jordan Dubrick <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Summarize the changes you made as part of this pull request.
This PR is responsible for adding a script for automating the release process for this repository. You can view the release process here.
With the process, the script can handle the following:
The user will need to create the release themselves based off the pre-created tag via GitHub and that will be reflected in the release process documentation after this PR is merged.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
resolves devfile/api#1450
Acceptance Criteria
Tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.