-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Arch Support for oci-registry builds and CI #240
Conversation
… functionality Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally the scripts and left some comments. One question in general I have is for the manifests and their importance on the script. Mostly because while I've seen this feature in the pas is the first time I see it in action :D
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm tested the scripts locally using my personal quay.io account and they were working correctly.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
Updating CI to support multi-arch image building
What does does this PR do / why we need it:
This PR contains the following changes:
build.sh
script to allow for easy building of different architecture images, by defaultlinux/amd64
will be built with no arguments passedoci-registry/README.md
to reflect the additional functionality ofbuild.sh
ci.yaml
to include QEMU for Docker so that the workflow can buildlinux/arm64
imagesci.yaml
to test the builds for bothlinux/amd64
andlinux/arm64
oci-registry
imagesbuild-multi-arch.sh
to enable multi-arch building and pushing for theoci-registry
images. This by default will use Docker as github workflows supports that, however, it also allows for podman to be used if we ever switch. This script handles the building of bothlinux/amd64
andlinux/arm64
images, the creation of the image manifest, and the pushing of all 3 items toquay.io/devfile/oci-registry
. The architecture specific images will be taggedamd64
andarm64
for their respective images, and the manifest will be taggednext
. Users should see no change in their workflow for pulling thequay.io/devfile/oci-registry:next
image, it will pull the proper architecture for the OS pulling.pushimage-next.yaml
to include QEMU for Docker as well as run the multi-arch script.Which issue(s) this PR fixes:
fixes devfile/api#1546
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: