-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema version validation changes #174
Schema version validation changes #174
Conversation
* schema version validation error response code changed from 500 to 400 * optional bugfix version allowed Signed-off-by: Michael Valdron <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 42.28% 45.69% +3.40%
==========================================
Files 6 6
Lines 1057 1057
==========================================
+ Hits 447 483 +36
+ Misses 567 533 -34
+ Partials 43 41 -2
☔ View full report in Codecov by Sentry. |
…must be 2.x or higher. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…maxSchemaVersion. Signed-off-by: Michael Valdron <[email protected]>
Testing against staging failing due to these changes to be tested not being merged and deployed to staging yet. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
index server
What does does this PR do / why we need it:
Changes contain the following:
2.2
and2.2.0
are accepted schema versionsWhich issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1128
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: