Fix icon base64data and code block formatting in CSV files #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
requested review from
johnmcollier,
yangcao77,
maysunfaisal and
kim-tsao
2 tasks
N/A |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 25.30% 26.43% +1.13%
==========================================
Files 25 25
Lines 1415 1415
==========================================
+ Hits 358 374 +16
+ Misses 1032 1020 -12
+ Partials 25 21 -4 ☔ View full report in Codecov by Sentry. |
thepetk
reviewed
Nov 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thepetk
pushed a commit
to thepetk/devfile-registry-operator
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Michael Valdron <[email protected]> Signed-off-by: thepetk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
It is reported in devfile/api#1354 that the icon is missing and code blocks are not formatting correctly under the embedded OperatorHub catalog in OpenShift. These changes mirror the formatting of the strings used in other bundle entries with expected results which should correct these problems.
Testing these changes under the OperatorHub.io preview tool does not break the currently working page.
Note: These changes require a patch version to be cut before devfile/api#1354 can be resolved.
Which issue(s) this PR fixes:
Fixes #?
devfile/api#1354
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: