-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace webhook validation #41
Add namespace webhook validation #41
Conversation
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…amespace. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…gistrieslist and devfileregistrieslist. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
… and delete the non-default namespace after tests end. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
d1c8083
to
fd16148
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage ? 22.72%
=======================================
Files ? 23
Lines ? 1307
Branches ? 0
=======================================
Hits ? 297
Misses ? 995
Partials ? 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
Adds namespace validation to webhooks for
devfileregistry
,devfileregistries
, andclusterdevfileregistrieslist
to prevent deployment to the default namespace.Which issue(s) this PR fixes:
Fixes #?
part of devfile/api#1092
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: