Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC dependency to fix CVE-2023-32731 vulnerability #175

Closed
wants to merge 1 commit into from

Conversation

michael-valdron
Copy link
Member

What does this PR do?:

Fixes the high risk vulnerability CVE-2023-32731 by updating the google.golang.org/grpc.

Which issue(s) this PR fixes:

part of devfile/api#1180

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign amisevsk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6c4a5b8) 59.72% compared to head (3a7ff54) 59.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files          41       41           
  Lines        5125     5125           
=======================================
  Hits         3061     3061           
  Misses       1868     1868           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-valdron
Copy link
Member Author

@michael-valdron
Copy link
Member Author

/unhold

@michael-valdron
Copy link
Member Author

Closing in favor of #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant