Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document unsupported devfile 2.2.x features #985

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

AObuchow
Copy link
Collaborator

What does this PR do?

Adds additional documentation regarding which DevFile 2.2.x features are not yet supported by DWO.

What issues does this PR fix or reference?

Fix #983

Is it tested? How?

n/a, though you can see how the document looks here.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@AObuchow AObuchow force-pushed the document_unsupported_api branch from 52e5743 to 7f4a662 Compare November 24, 2022 17:01
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 54.11% // Head: 54.11% // No change to project coverage 👍

Coverage data is based on head (0b99231) compared to base (9a339c7).
Patch has no changes to coverable lines.

❗ Current head 0b99231 differs from pull request most recent head 0cd46ce. Consider uploading reports for the commit 0cd46ce to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files          44       44           
  Lines        2770     2770           
=======================================
  Hits         1499     1499           
  Misses       1135     1135           
  Partials      136      136           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AObuchow AObuchow force-pushed the document_unsupported_api branch from 0b99231 to 0720069 Compare November 24, 2022 23:27
Comment on lines 11 to 13
| `components.volume.size` | https://github.com/devfile/devworkspace-operator/issues/947[Compute required size for per-workspace PVC when all volumes have sizes specified.]
| `components.image` | https://github.com/eclipse/che/issues/21186[Support Devfile v2 outer loop components of type image and kubernetes]
| `components.custom` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: the table is nicely aligned in plaintext except for these three lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AObuchow AObuchow force-pushed the document_unsupported_api branch from 0720069 to 76506f8 Compare November 28, 2022 15:20
@openshift-ci openshift-ci bot removed the lgtm label Nov 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2022

New changes are detected. LGTM label has been removed.

@AObuchow AObuchow force-pushed the document_unsupported_api branch from 76506f8 to 3d2dc3e Compare November 28, 2022 15:21
@AObuchow AObuchow force-pushed the document_unsupported_api branch from 3d2dc3e to 0cd46ce Compare November 28, 2022 15:22
@AObuchow
Copy link
Collaborator Author

/retest

3 similar comments
@AObuchow
Copy link
Collaborator Author

/retest

@AObuchow
Copy link
Collaborator Author

/retest

@AObuchow
Copy link
Collaborator Author

/retest

@AObuchow AObuchow merged commit 7c0986a into devfile:main Nov 29, 2022
@AObuchow AObuchow deleted the document_unsupported_api branch November 29, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document unsupported Devfile 2.x features
3 participants