-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: document unsupported devfile 2.2.x features #985
Conversation
52e5743
to
7f4a662
Compare
Codecov ReportBase: 54.11% // Head: 54.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 54.11% 54.11%
=======================================
Files 44 44
Lines 2770 2770
=======================================
Hits 1499 1499
Misses 1135 1135
Partials 136 136 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0b99231
to
0720069
Compare
docs/unsupported-devfile-api.adoc
Outdated
| `components.volume.size` | https://github.com/devfile/devworkspace-operator/issues/947[Compute required size for per-workspace PVC when all volumes have sizes specified.] | ||
| `components.image` | https://github.com/eclipse/che/issues/21186[Support Devfile v2 outer loop components of type image and kubernetes] | ||
| `components.custom` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: the table is nicely aligned in plaintext except for these three lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0720069
to
76506f8
Compare
New changes are detected. LGTM label has been removed. |
76506f8
to
3d2dc3e
Compare
Fix devfile#983 Signed-off-by: Andrew Obuchowicz <[email protected]>
3d2dc3e
to
0cd46ce
Compare
/retest |
3 similar comments
/retest |
/retest |
/retest |
What does this PR do?
Adds additional documentation regarding which DevFile 2.2.x features are not yet supported by DWO.
What issues does this PR fix or reference?
Fix #983
Is it tested? How?
n/a, though you can see how the document looks here.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che