Update GitHub Action for PRs to use go 1.15.13 and old version of addlicense #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required due to golang/go#44557 -- go 1.16 deprecates the ioutil package and introduces a new package io in its place. Go versions below 1.15.10 can fail if a library or dependency uses the go 1.16 package, e.g. for addlicense: build github.com/google/addlicense: cannot load io/fs: malformed module path "io/fs": missing dot in first path element This commit updates to Go 1.15.13, as that is what's used in the current builder image for the controller Signed-off-by: Angel Misevski <[email protected]>
As of the commit following the one used in this PR, addlicense requires Go 1.16 (go get fails on 1.15 and below) Signed-off-by: Angel Misevski <[email protected]>
amisevsk
force-pushed
the
update-gh-action-go-version
branch
from
250a2bf to
8700858
Compare
JPinkney
approved these changes
Aug 10, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path |
amisevsk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR separates out the change described in #540 (comment) by updating the GH action to use go 1.15.13 and avoid issue golang/go#44557
It also pins the version of addlicense used in github actions to google/addlicense@99ebc9c, as the following commits make addlicense require Go 1.16
What issues does this PR fix or reference?
I noticed that the automated check for #544 is failing due to
Is it tested? How?
Hopefully all actions pass :)
PR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test