Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build configs in ocp #131

Closed
wants to merge 3 commits into from
Closed

fix: build configs in ocp #131

wants to merge 3 commits into from

Conversation

codekow
Copy link

@codekow codekow commented Sep 28, 2023

Builds in ocp are failing from the universal/ubi8/Dockerfile

---
apiVersion: image.openshift.io/v1
kind: ImageStream
metadata:
  name: udi
---
apiVersion: build.openshift.io/v1
kind: BuildConfig
metadata:
  name: udi-base
spec:
  source:
    type: Git
    git:
      uri: 'https://github.com/devfile/developer-images.git'
    contextDir: /base/ubi8
  strategy:
    type: Docker
    dockerStrategy:
      dockerfilePath: Dockerfile
  output:
    to:
      kind: ImageStreamTag
      name: udi:base
  triggers:
    - type: ImageChange
    - type: ConfigChange
---
apiVersion: build.openshift.io/v1
kind: BuildConfig
metadata:
  name: udi-universal
spec:
  source:
    type: Git
    git:
      uri: 'https://github.com/devfile/developer-images.git'
    contextDir: /universal/ubi8
  strategy:
    type: Docker
    dockerStrategy:
      dockerfilePath: Dockerfile
      from:
        kind: ImageStreamTag
        name: 'udi:base'
  output:
    to:
      kind: ImageStreamTag
      name: udi:universal
  triggers:
    - type: ImageChange
    - type: ConfigChange

Lets try another way to define the inline command

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codekow

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codekow
Copy link
Author

codekow commented Sep 28, 2023

Building from my branch:

---
apiVersion: image.openshift.io/v1
kind: ImageStream
metadata:
  name: udi
---
apiVersion: build.openshift.io/v1
kind: BuildConfig
metadata:
  name: udi-base
spec:
  source:
    type: Git
    git:
      uri: 'https://github.com/devfile/developer-images.git'
    contextDir: /base/ubi8
  strategy:
    type: Docker
    dockerStrategy:
      dockerfilePath: Dockerfile
  output:
    to:
      kind: ImageStreamTag
      name: udi:base
  triggers:
    - type: ImageChange
    - type: ConfigChange
---
apiVersion: build.openshift.io/v1
kind: BuildConfig
metadata:
  name: udi-universal
spec:
  source:
    type: Git
    git:
      uri: 'https://github.com/codekow/developer-images.git'
      ref: 'fix-buildah-on-ocp'
    contextDir: /universal/ubi8
  strategy:
    type: Docker
    dockerStrategy:
      dockerfilePath: Dockerfile
      from:
        kind: ImageStreamTag
        name: 'udi:base'
  output:
    to:
      kind: ImageStreamTag
      name: udi:universal
  triggers:
    - type: ImageChange
    - type: ConfigChange

@codekow codekow marked this pull request as draft September 29, 2023 00:05
@codekow
Copy link
Author

codekow commented Sep 29, 2023

It appears that buildah is not handling the Dockerfile well

@codekow
Copy link
Author

codekow commented Sep 29, 2023

See containers/buildah#3474

Closing due to issue w/ buildah

@codekow codekow closed this Sep 29, 2023
@codekow codekow deleted the fix-buildah-on-ocp branch September 29, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant