Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributions field to the DevWorkspace custom resource #879

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

amisevsk
Copy link
Contributor

What does this PR do?:

Implements new field in DevWorkspace custom resource .spec.contributions according to #874. See issue for details on design/reasoning.

This PR basically copies fields from the existing pluginComponent into a new field in the DevWorkspace CR.

Which issue(s) this PR fixes:

Closes #874

How to test changes / Special notes to the reviewer:

amisevsk added 2 commits June 23, 2022 16:47
Add field `.spec.contributions` to the DevWorkspace custom resource to
allow specifying additional resources (e.g. editors, etc.) that should
be included in a DevWorkspace. This allows for adding additional
components to a workspace while using the .spec.template field to store
a devfile.

Signed-off-by: Angel Misevski <[email protected]>
@amisevsk amisevsk requested a review from l0rd June 23, 2022 20:56
@amisevsk amisevsk changed the title Container contributions Add contributions field to the DevWorkspace custom resource Jun 23, 2022
@amisevsk amisevsk marked this pull request as ready for review July 22, 2022 21:40
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, l0rd

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk amisevsk merged commit d563c4c into devfile:main Sep 13, 2022
@amisevsk amisevsk deleted the containerContributions branch September 13, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: begin process of moving plugin components in DevWorkspace spec
2 participants