potential increase in code cov for resp body closing

Signed-off-by: Jordan Dubrick <[email protected]>

pkg/apis/recognizer/devfile_recognizer_test.go

@@ -16,6 +16,9 @@ import (
 	"reflect"
 	"runtime"
 	"testing"
+	"net/http"
+	"net/http/httptest"
+	"io"
 
 	"github.com/devfile/alizer/pkg/apis/model"
 	"github.com/stretchr/testify/assert"
@@ -217,6 +220,46 @@ func TestGetUrlWithVersions(t *testing.T) {
 	}
 }
 
+func TestResponseBodyClosing(t *testing.T) {
+	tests := []struct {
+		name             string
+		mockServerConfig func(w http.ResponseWriter, r *http.Request)
+	}{
+		{
+			name: "Successful response body closing",
+			mockServerConfig: func(w http.ResponseWriter, r *http.Request) {
+				w.WriteHeader(http.StatusOK)
+				w.Write([]byte("response body content"))
+			},
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(tt *testing.T) {
+			// Setup a mock HTTP server
+			server := httptest.NewServer(http.HandlerFunc(tc.mockServerConfig))
+			defer server.Close()
+
+			// Perform a request to the mock server
+			resp, err := http.Get(server.URL)
+			assert.NoError(t, err, "Unexpected error during HTTP GET")
+
+			// Close the response body
+			func() {
+				defer func() {
+					if err := resp.Body.Close(); err != nil {
+						fmt.Printf("error closing file: %s", err)
+					}
+				}()
+
+				body, err := io.ReadAll(resp.Body)
+				assert.NoError(t, err, "Unexpected error reading response body")
+				assert.Equal(t, "response body content", string(body), "Unexpected response body content")
+			}()
+		})
+	}
+}
+
 func TestMatchDevfiles(t *testing.T) {
 	tests := []struct {
 		name                string

test/check_registry/check_registry_test.go

@@ -3,6 +3,10 @@ package main
 import (
 	"net/url"
 	"testing"
+	"net/http"
+	"net/http/httptest"
+	"io"
+	"fmt"
 
 	"github.com/stretchr/testify/assert"
 )
@@ -76,3 +80,43 @@ func TestGetStarterProjects(t *testing.T) {
 		})
 	}
 }
+
+func TestResponseBodyClosingStarterProjects(t *testing.T) {
+	tests := []struct {
+		name             string
+		mockServerConfig func(w http.ResponseWriter, r *http.Request)
+	}{
+		{
+			name: "Successful response body closing",
+			mockServerConfig: func(w http.ResponseWriter, r *http.Request) {
+				w.WriteHeader(http.StatusOK)
+				w.Write([]byte("response body content"))
+			},
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(tt *testing.T) {
+			// Setup a mock HTTP server
+			server := httptest.NewServer(http.HandlerFunc(tc.mockServerConfig))
+			defer server.Close()
+
+			// Perform a request to the mock server
+			resp, err := http.Get(server.URL)
+			assert.NoError(t, err, "Unexpected error during HTTP GET")
+
+			// Close the response body
+			func() {
+				defer func() {
+					if err := resp.Body.Close(); err != nil {
+						fmt.Printf("error closing file: %s", err)
+					}
+				}()
+
+				body, err := io.ReadAll(resp.Body)
+				assert.NoError(t, err, "Unexpected error reading response body")
+				assert.Equal(t, "response body content", string(body), "Unexpected response body content")
+			}()
+		})
+	}
+}