Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timeframe list after retrain #149

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Mar 12, 2024

May fix #148.

@LanesGood I believe what was happening is that the timeframe list wasn't being updated after retraining, so when you switch and go back to the last checkpoint the last timeframe is not available in the app state. This change should fix it.

How to test: create project, predict, retrain, switch to base model, switch to last checkpoint, timeframe list is correct. You can also confirm via the log messages related to timeframe list.

@vgeorge vgeorge requested a review from LanesGood March 12, 2024 16:33
Copy link
Member

@LanesGood LanesGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to switch around between multiple checkpoints and timeframes with this one. Nice

@vgeorge vgeorge merged commit 6c5bd58 into develop Mar 12, 2024
3 checks passed
@vgeorge vgeorge deleted the fix/timeframe-list-after-retrain branch March 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint timeframe does not apply
2 participants