possible fix for always assuming WGS84 #157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is slightly related to developmentseed/cogeo-mosaic#234 and developmentseed/cogeo-mosaic#233
Currently morecantile assumes WGS84 as the geographic_crs for most cases unless the user explicitly over-rides it via the api. However, saving TMSs doesn't always preserve the geographic_crs in json representations (it's not actually an allowed field from the TMS v2 spec, or rather not one explicitly encouraged) so depending on the situation there are cases when the the main CRS is defined for a non-earth celestial body, but the geographic_crs parameter will return 4326 depending on how the TMS is defined.
I think however the geographic crs is always discoverable directly from the CRS of the tms. If given a projected CRS,
.geodetic_crs
will always return a value, if given a GEOGCRS then the geographic_crs is essentially the same anyways. This PR (should) preserve the ability to allow explicit overrides, but will default to one appropriate to the CRS if not defined. I am not sure how robust this idea is though, so please throw stones at this/think of things I should test for