-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update runtimes and add pgstac customization options #100
feat: update runtimes and add pgstac customization options #100
Conversation
sql.SQL( | ||
"CREATE INDEX IF NOT EXISTS searches_mosaic ON searches ((true)) WHERE metadata->>'type'='mosaic';" | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is taken from eoapi repo
30bf562
to
1bbd801
Compare
deployment workflow https://github.com/developmentseed/eoapi-cdk/actions/runs/8045501396 |
Co-authored-by: Emile Tenezakis <[email protected]>
Questions for my understanding
What were we doing before, was it disabled by default? |
@emileten we were adding the mosaic index by default but not the context extension, maybe we can switch back to false 👍 |
I'll defer to you on this decision, I don't know much about these options. Doesn't sound like it hurts to have the context on by default ? |
A live example of the bootstrapper logs The workflow failed again, there's something we need to fix in the bootstrapper changes https://github.com/developmentseed/eoapi-cdk/actions/runs/8045602231/job/21971192880#step:9:2478
Also
|
@vincentsarago just checking, were you expecting the last commit to fix the bug ? or is there more to do |
I was hopping yes 😅 but couldn't see where I had to click to run the deployment workflow |
ugh sorry, just started one. Will show you later |
@vincentsarago looks like we still have the problem
I can take a look tomorrow as well. FYI to run a deployment:
|
@emileten let's fall back to pgstac 0.7.10 to validate the changes and then we can debug why it doesn't work for pgstac 0.8.4 |
@vincentsarago like this 0d675e2? |
@emileten just pgstac, we can keep titiler-pgstac and tipg to the latest version |
This reverts commit 0d675e2.
Ok seems to work https://github.com/developmentseed/eoapi-cdk/actions/runs/8204255860/job/22438560336#step:10:798. Now we need to
😄 |
there seems to be a 0.8.3 change that sounds like it could have triggered this https://github.com/stac-utils/pgstac/blob/e0b7de4c9c8130c55de9fe6eb0a87324cd705135/CHANGELOG.md?plain=1#L37 we can try with the previous version |
@emileten if I understand well looking at #100 (comment) it seems the
in
when we use eoapi-cdk/lib/database/bootstrapper_runtime/handler.py Lines 231 to 232 in 4425253
username/password (must be After the migration we then grant the username/password ( eoapi-cdk/lib/database/bootstrapper_runtime/handler.py Lines 133 to 135 in 4425253
so to me it seems that we should cc @bitner |
@emileten @vincentsarago Once pgstac has been installed, you can assign these roles to other database login roles. Ideally, you would use least-access necessary roles for different tasks. Best practice would be to have three roles to interact with pgstac.
|
* (fix): fix database bootstrap * fix handler * update to pgstac 0.8.5
This PR closes #88 and add customizations option for PgSTAC bootstrap to:
Merge request description