upgrade postcss to fix automodules (fixes #653) #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like its failing for this test: https://github.com/developit/microbundle/tree/master/test/fixtures/css-modules--string Not completely sure yet what is going on with the differing snapshots 🤔 |
|
Weird - JS sizes went up too. |
|
Turns out our snapshots were just incorrect. |
|
@developit Sadly this cannot be done because rollup v1 is not supported anymore We're currently blocked by egoist/rollup-plugin-postcss#295 to update microbundle to rollup v2. I could update #680 to use a git package instead or publish the patch under @wardpeet npm package if that helps. |
|
Going to close this because #680 will fix this once new version of postcss is being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.