Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rollup extend #709

Closed
domoritz opened this issue Aug 23, 2020 · 3 comments
Closed

Support rollup extend #709

domoritz opened this issue Aug 23, 2020 · 3 comments

Comments

@domoritz
Copy link

Rollup supports extending names with --extend as documented in https://rollupjs.org/guide/en/#outputextend. It would be great if microbundle also supported this option.
@developit
Copy link
Owner

It's been proposed, but I think the only way we'd be able to do this would be to allow dot-notation in the "amdName" package.json field. Microbundle isn't a configurable bundler, we already have Rollup for that. It's an optimization for the 90% case.

@domoritz
Copy link
Author

Couldn't you support --name foo --extend command line options and then microbundle could pass extend to rollup so that foo gets extended instead of overwritten?

developit added a commit that referenced this issue Aug 31, 2020
@developit
Support global extend via amdName
0005a96 
Using a prefixed name like `{ "amdName": "global.foo" }` will trigger Rollup's `output.extend` option. This addresses the use-case from #709 without adding another CLI flag.
@developit developit mentioned this issue Aug 31, 2020
Merged
marvinhagemeister pushed a commit that referenced this issue Aug 31, 2020
@developit
Support global extend via amdName (#713)
ffcc9d9 
* Support global extend via amdName

Using a prefixed name like `{ "amdName": "global.foo" }` will trigger Rollup's `output.extend` option. This addresses the use-case from #709 without adding another CLI flag.

* Create chilled-paws-confess.md

* Update chilled-paws-confess.md
@wardpeet
Copy link
Collaborator

wardpeet commented Sep 1, 2020

Will be published in next release. Hopefully in a day or 2 :) Thank you for letting us know!

@wardpeet wardpeet closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@developit @domoritz @wardpeet