Make puppeteer a peerDependency #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
force-pushed
the
puppeteer-peerdep
branch
from
6f64fae to
e870621
Compare
andrewiggins
approved these changes
Jul 7, 2020
package.json
Outdated
| "sade": "^1.7.3", | ||
| "script-loader": "^0.7.2", | ||
| "simple-code-frame": "^1.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "puppeteer": "^4.0.1", |
There was a problem hiding this comment.
We could probably relax this a bit and do something like ">=2" I think. May be able to do "*" since karma-chrome-launcher uses the chrome.exe directly I think and doesn't use the puppeteer API directly
There was a problem hiding this comment.
oh good point 👍 Updated the PR 🎉
|
Reminder, this'll require a major semver update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicate chromium downloads if the user has a different version installed in his project.