Ability to add custom CA roots for downloads via env var #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to set a custom CA root for downloads, e.g. for transparent caching of downloads via a proxy.
Test Plan
Open Questions
I saw that this tries to reuse as much from npm/node as possible to make the integration with electron-builder etc. very convenient. I'm not sure if there's a more app-builder-specific env var as an alternative to that should be accepted here?
Is there any place where the env vars are currently documented and this should be mentioned?