Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add custom CA roots for downloads via env var #28

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

passy
Copy link
Contributor

@passy passy commented Mar 23, 2020

This allows you to set a custom CA root for downloads, e.g. for transparent caching of downloads via a proxy.

Test Plan

env HTTP_PROXY=http://localhost:8080 HTTPS_PROXY=http://localhost:8080 NODE_EXTRA_CA_CERTS=~/.mitmproxy/mitmproxy-ca-cert.pem ./app-builder download --url="https://github.com/facebook/flipper/releases/download/v0.34.0/Flipper-mac.dmg" --output="/tmp/download"

Open Questions

I saw that this tries to reuse as much from npm/node as possible to make the integration with electron-builder etc. very convenient. I'm not sure if there's a more app-builder-specific env var as an alternative to that should be accepted here?

Is there any place where the env vars are currently documented and this should be mentioned?

@develar
Copy link
Owner

develar commented Apr 7, 2020

Is there any place where the env vars are currently documented and this should be mentioned?

No.

if there's a more app-builder-specific env var as an alternative to that should be accepted here?

If you use it for nodejs, NODE_EXTRA_CA_CERTS name is ok. If not, we can think about what prefix should be used to make name more generic.

@develar develar merged commit 47c3e0a into develar:master Apr 7, 2020
@passy
Copy link
Contributor Author

passy commented Apr 7, 2020

Thanks for merging. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants