Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change node module symlink to real path #120

Merged
merged 6 commits into from
Jun 16, 2024

Conversation

beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Jun 13, 2024

#92

package.json

{
  "name": "pnpm-demo",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "react": "^18.2.0"
  }
}

actual results:
{"name":"react","version":"18.2.0","dir":"C:\\Users\\xxxxx\\Code\\app-builder\\pkg\\node-modules\\pnpm-demo\\node_modules\\react"}

expected result:
{"name":"react","version":"18.2.0","dir":"C:\\Users\\xxxxx\\Code\\app-builder\\pkg\\node-modules\\pnpm-demo\\node_modules\\.pnpm\\[email protected]\\node_modules\\react"}

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 47e4a40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-bin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beyondkmp beyondkmp changed the title Fix: change all symlink to real path fix: change all symlink to real path Jun 13, 2024
@beyondkmp beyondkmp changed the title fix: change all symlink to real path fix: change node module symlink to real path Jun 13, 2024
@mmaietta
Copy link
Collaborator

@beyondkmp thanks for tackling this! I've merged the other PR, could you please rebase off latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants