Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return size info when converting icon #71

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

0xjac
Copy link
Contributor

@0xjac 0xjac commented Oct 24, 2021

Closes #42

@develar I had the same problem as described in #42 with packaged app which had an icon with in the wrong 0x0 directory. This should return the right size for all formats (icns, ico, set).

@hanjukim
Copy link

@develar When will this be merged? I am having same problem.

@0xjac
Copy link
Contributor Author

0xjac commented Feb 6, 2022

@hanjukim if it helps until this is merged, you can have a look at the fix I used here (assuming you are also using electron builder) which essentially fulfills the promise early and then goes over all the icon sizes to replace any size of 0 with an hard-coded value.

@develar I'm sure you're busy, but if there is anything I can do to assist with to merge this PR let me know. 🙂

@develar develar merged commit c92c3a2 into develar:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG Icon Size 0x0?
3 participants