Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PNG Icon Size 0x0? #42

Closed
Hyperdraw opened this issue Sep 14, 2020 · 0 comments · Fixed by #71
Closed

PNG Icon Size 0x0? #42

Hyperdraw opened this issue Sep 14, 2020 · 0 comments · Fixed by #71

Comments

@Hyperdraw
Copy link

app-builder/pkg/icons/icon-converter.go

Line 187 in 1cceb8f

return []IconInfo{{File: resolvedPath}}, nil

When Electron Builder is given a single PNG source icon and calls app-builder-bin, it outputs "size": 0, likely because of this line, which is causing electron builder to put the icon in the wrong directory in the package.
@antonsoroko antonsoroko mentioned this issue Feb 24, 2021
Open
@eladyn eladyn mentioned this issue Mar 24, 2021
Open
0xjac added a commit to 0xjac/app-builder that referenced this issue Oct 24, 2021
@0xjac
fix: Return size info when converting icon
356a652 
Closes develar#42
@0xjac 0xjac mentioned this issue Oct 24, 2021
Merged
@0xjac 0xjac mentioned this issue Nov 1, 2021
Merged
@mairin mairin mentioned this issue Jul 12, 2022
Closed
develar pushed a commit that referenced this issue Sep 12, 2023
@0xjac
fix: Return size info when converting icon (#71)
c92c3a2 
Closes #42
@Declan-F Declan-F mentioned this issue Feb 21, 2024
Closed
@github-actions github-actions bot mentioned this issue Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Hyperdraw