Retry failed downloads without the specified RootCAs to use the default CAs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig, retry download with default RootCA. On Windows x509.SystemCertPool() always returns nil which means that Windows users with NODE_EXTRA_CA_CERTS defined will only get the NODE_EXTRA_CA_CERTS. Therefore, if RootCAs was created, and the download fail, retry with RootCAs as nil to allow Go to figure out the proper CAs. Signed-off-by: Samuel HULTGREN <[email protected]>
|
@develar can you please have a look at this PR? Like I said, it is not a complete fix for the issues on Windows (since not all certificates will be available at the same time), but at least it will use the system certificates on the retry if NODE_EXTRA_CA_CERTS was used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows x509.SystemCertPool() always returns nil which means that Windows users
with NODE_EXTRA_CA_CERTS defined will only get the NODE_EXTRA_CA_CERTS.
Therefore, if RootCAs was created, and the download fail, retry with RootCAs as nil to allow Go to figure out the proper CAs.
Improves the situation on Windows of the issue introduced with pull #28 for issue #4 .
Issue still remains though that on Windows the system certificates and the NODE_EXTRA_CA_CERTS will not be available at the same time for a certain download task.