Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search functionality on collections, Features, Templates #325

Merged
merged 19 commits into from
Feb 22, 2024
Merged

Add search functionality on collections, Features, Templates #325

merged 19 commits into from
Feb 22, 2024

Conversation

bamurtaugh
Copy link
Member

@bamurtaugh bamurtaugh commented Nov 17, 2023 •
edited
Loading

This pull request adds search functionality for collections, Templates, and Features.

  • Added an input field for searching tables

  • Implemented JavaScript logic to filter the table rows based on the search input

These changes improve the user experience by allowing users to easily search and find specific items in each table.

@bamurtaugh bamurtaugh requested a review from a team as a code owner November 17, 2023 01:41
samruddhikhandale
samruddhikhandale reviewed Nov 18, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding these changes, this will be so helpful for folks! 🎉
Left few comments.

collections.html Show resolved Hide resolved
collections.html Outdated Show resolved Hide resolved
collections.html Show resolved Hide resolved
@bamurtaugh
Copy link
Member Author

Ah sorry for any confusion! This was one of my demo scenarios during Ignite and a sample PR - I'll close this 😄

@bamurtaugh bamurtaugh closed this Nov 20, 2023
@samruddhikhandale
Copy link
Member

samruddhikhandale commented Nov 20, 2023 •
edited
Loading

Ah! 🤦‍♀️

@bamurtaugh FYI, this is really a good PR, adding a search functionality would definitely be helpful for folks.
Let me know if I could help to get this merged in.

@bamurtaugh bamurtaugh reopened this Feb 17, 2024
@bamurtaugh
Copy link
Member Author

Thanks so much for the feedback @samruddhikhandale and I agree we should reopen, especially as part of devcontainers/spec#405! Let me address your feedback and then re-request review.

This was referenced Feb 17, 2024
Open
Open
@bamurtaugh bamurtaugh changed the title Add search functionality and style to collection table Add search functionality on collections, Features, Templates Feb 17, 2024
@alexdima alexdima mentioned this pull request Feb 20, 2024
Closed
5 tasks
samruddhikhandale
samruddhikhandale approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! ⚡

collections.html Show resolved Hide resolved
@bamurtaugh bamurtaugh merged commit 628e1ad into gh-pages Feb 22, 2024
1 check passed
@bamurtaugh bamurtaugh deleted the bamurtaugh/ignite-copilot branch February 22, 2024 19:24
@bamurtaugh bamurtaugh mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bamurtaugh @samruddhikhandale