Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update maintainer name to 'The Dev Container Contrib Community' #168

Closed
wants to merge 1 commit into from

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Mar 7, 2023

@danielbraun89 - I was looking through our index and saw that we're currently listing your name for the contributions to your awesome devcontainers-contrib repos!

Please let me know if you'd like to keep it as-is, but I think it would be clearer to list these Features with something along the lines of 'The Dev Container Contrib Community'.

@joshspicer joshspicer requested a review from a team as a code owner March 7, 2023 16:36
@eitsupi
Copy link
Contributor

eitsupi commented Mar 7, 2023

Note that only one member exists in devcontainers-contrib organization, and @danielbraun89 clearly declared in https://github.com/devcontainers-contrib/features/issues/316 that they had no intention of adding another member.
(@danielbraun89 has deleted https://github.com/devcontainers-contrib/features/issues/316 and cannot confirm this now, but I believe @jcbhmr, who was discussing this with @danielbraun89 in https://github.com/devcontainers-contrib/features/issues/316, has the right to comment on this PR)

c.f. devcontainers-contrib/templates#13 (comment)

Given that this organization seems to be just "danielbraun98's devcontainers stash" instead of a Community Devcontainers organization, I think that you're right, you are justified to keep the Terraform template as-is.

@jcbhmr
Copy link
Contributor

jcbhmr commented Mar 7, 2023

My understanding is that the @devcontainers-contrib organization is a tad misleading in name. The organization functions more as a "@danielbraun89's namespace for devcontainer features" than it does as a proper "community hub" for features. Sure, you can suggest features, open PRs, but, as @eitsupi has already stated:

Note that only one member exists in devcontainers-contrib organization, and @danielbraun89 clearly declared in https://github.com/devcontainers-contrib/features/issues/316 that they had no intention of adding another member.

The gist is that it's less a "community hub" of sorts (like I originally thought; you can see this in the changes I made in hope that it would grow) and more of "danielbraun98's devcontainers stash" sorta like https://github.com/codspace is for @joshspicer. The maintenance and expansion will be limited due to it being, in essence, a side project or a custom namespace; and that's OK, I just don't know how you want to represent that in the name/author of the org.

Note that only one member exists in devcontainers-contrib organization, and @danielbraun89 clearly declared in https://github.com/devcontainers-contrib/features/issues/316 that they had no intention of adding another member.
(@danielbraun89 has deleted https://github.com/devcontainers-contrib/features/issues/316 and cannot confirm this now, but I believe @jcbhmr, who was discussing this with @danielbraun89 in https://github.com/devcontainers-contrib/features/issues/316, has the right to comment on this PR)

In reference to that deleted 316 issue, which I know you also mentioned in devcontainers-contrib/features#317, it was where I inquired about how we could improve the workflow to avoid being tied to a single person's throughput. We discussed the outlines of what @danielbraun89 (the ultimate authority of @devcontainers-contrib) wanted as a vision. It was decided that maybe I could open some PRs to put a notice in the CONTRIBUTING.md of the various repos that this was a single-person led org that had no intention to expand due to time and other commitments. This clarified the vision and gradually led me to stop open PRs and retract my suggested improvements that I knew would never happen due to it being, in essence, danielbraun89/devcontainer-features just in a different namespace, not a true "community hub" like @vercel-community or other similar projects. All in all, I have zero influence over the @devcontainers-contrib project now.

@joshspicer
Copy link
Member Author

Thanks for the context @jcbhmr and @eitsupi. My intention here was only to fix what I thought was an oversight (@danielbraun89 was an early adopter to our index and the key maintainer in this YAML file might be a bit vague).

Given what you all have shared, i'll close this PR and allow Daniel to reopen if he so choose.

PS: Thank you both for your awesome contributions, both within the devcontainers-contrib org and outside :)

@joshspicer joshspicer closed this Mar 7, 2023
@danielbraun89
Copy link
Contributor

@danielbraun89 - I was looking through our index and saw that we're currently listing your name for the contributions to your awesome devcontainers-contrib repos!

Please let me know if you'd like to keep it as-is, but I think it would be clearer to list these Features with something along the lines of 'The Dev Container Contrib Community'.

Although this is now closed - I want to thank you for bringing this up
devcontainer-contrib repo has over 15+ (greatly welcomed!) contributers but indeed - currently it is mainly I who code, generate, and maintain the features. I now understand "devcontainer-contrib" is a loaded name. It comes with certain minimal expectations (for example of adding contributers as privileged organizational members). In order to avoid friction in the future, I simply plan to rename the organization to something different (Will have to make sure however, that old packages still remain under same repo name, in order to not break anybody who rely on them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants