Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Namespace CLI via Github Releases #54

Merged
merged 2 commits into from
Oct 19, 2024
Merged

feat: add Namespace CLI via Github Releases #54

merged 2 commits into from
Oct 19, 2024

Conversation

pl4nty
Copy link

@pl4nty pl4nty commented Oct 15, 2024

@koralowiec koralowiec self-requested a review October 18, 2024 19:20
koralowiec
koralowiec requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I left one change request

test/namespace-cli/scenarios.json Show resolved Hide resolved
@koralowiec
Copy link
Member

Let's merge it!

@koralowiec koralowiec merged commit 6dd9d05 into devcontainers-extra:main Oct 19, 2024
4 checks passed
@pl4nty pl4nty deleted the feat/add-namespace-cli branch October 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koralowiec koralowiec koralowiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pl4nty @koralowiec