Skip to content
This repository has been archived by the owner on Jan 12, 2025. It is now read-only.

Question regarding feature contribution #319

Open
sdrzazga opened this issue Feb 16, 2023 · 3 comments · Fixed by #323
Open

Question regarding feature contribution #319

sdrzazga opened this issue Feb 16, 2023 · 3 comments · Fixed by #323
Assignees

Comments

@sdrzazga
Copy link

Hi.

I frequently use the following tools and was wondering, if I could contribute them perhaps as features?

Many thanks for considering my request.

@danielbraun89 danielbraun89 self-assigned this Feb 16, 2023
danielbraun89 added a commit that referenced this issue Feb 16, 2023
danielbraun89 added a commit that referenced this issue Feb 16, 2023
* Question regarding feature contribution
Fixes #319

* fix: jfrog permissions
@danielbraun89
Copy link
Member

Thanks @sdrzazga for bringing up these tools, I took it as an opportunity to test the flexibility of our new feature-definition approach 😄

Jfrog CLI is easy enough, it has multiple straight forward options so it was easy to include several of them (curl based, npm based, and homebrew based)

mongodb atlas cli - It has an easy tar.gz installation process - but not one that is easy to automate (hard to resolve what is the latest version ,etc). I have found an official brew repo (homebrew works on linux too) so I have added it, but its non-optimal (slower installation)

mongo-tools is more complicated -same simple but hard-to-automate tar.gz process, and I would have used the asdf installation - but it appears deprecated. will revisit in the future

pull request for the above is: #323

I will keep this issue open until all features are appropriately implemented (by me or someone else)

@danielbraun89 danielbraun89 reopened this Feb 16, 2023
@sdrzazga
Copy link
Author

Hello @danielbraun89 .

Thank you very much for the swift response and implementation of JFrog CLI as a feature.
I'm a little busy these days, but I'll definitely try to implement MongoDB Atlas CLI & MongoDB Database Tools.

@evilhamsterman
Copy link

This project is not associated with the devcontainer project and appears to have been abandoned #628 . The official project has removed all devcontainer-contrib features from their listing. devcontainers/devcontainers.github.io#451. There is a fork that is being worked on to update and maintain the features https://github.com/devcontainers-extra/features

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants