This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
48 support file download #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jevgenijusmarinuskinas
commented
Feb 22, 2021
•
jevgenijusmarinuskinas
commented
- Added new method downloadFile.
- Added tests.
- Webkit is skipped for now (bug registered).
added 5 commits
February 5, 2021 12:21
…a. Added test data.
…ethod downloadFile. Added tests.
jevgenijusmarinuskinas
requested review from
Martynienas,
ernestas-zekas and
vaidasmaciulis
vaidasmaciulis
suggested changes
Feb 25, 2021
| @@ -30,6 +30,7 @@ | |||
| "@babel/preset-env": "^7.0.0", | |||
| "async-retry": "^1.0.0", | |||
| "axios": "^0.21.1", | |||
| "fs-extra": "^9.1.0", | |||
There was a problem hiding this comment.
If this is only for empty dir, perhaps
fs.rmdir(dir, { recursive: true }) can be used instead?
There was a problem hiding this comment.
This one does not work properly when directory has files. fs-extra removed files from the dear. I think it is good to have it in our package for extra methods related to files.
vaidasmaciulis
approved these changes
Mar 4, 2021
added 2 commits
March 4, 2021 13:27
ernestas-zekas
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.