Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

#85 Refactor clicks and hover methods #97

Merged
merged 2 commits into from
Feb 18, 2021
Merged

#85 Refactor clicks and hover methods #97

merged 2 commits into from
Feb 18, 2021

Conversation

ernestas-zekas
Copy link
Collaborator

@ernestas-zekas ernestas-zekas commented Feb 9, 2021 •
edited
Loading

  • Refactored getCoordinates method;
  • Refactored click method;
  • Refactored doubleclick mehtod;
  • Refactored right-click mehtod;
  • Refactored hover mehtod;
  • Removed goToUrlAndLoad method from helpers class (page.goto is enough which can be used with different options)
  • Removed goToUrlAndLoad example test.
    image

@ernestas-zekas
#85 - Refactored getCoordinates method;
65aaf96 
- Refactored click method;
- Refactored doubleclick mehtod;
- Refactored right-click mehtod;
- Refactored hover mehtod;
- Removed goToUrlAndLoad method from helpers class;
- Removed goToUrlAndLoad example test.
vaidasmaciulis
vaidasmaciulis suggested changes Feb 17, 2021
View reviewed changes
framework/Element.js Outdated Show resolved Hide resolved
@ernestas-zekas ernestas-zekas merged commit a34bef7 into playwright Feb 18, 2021
@ernestas-zekas ernestas-zekas deleted the 85-refactor-click-and-hover branch February 18, 2021 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vaidasmaciulis vaidasmaciulis vaidasmaciulis approved these changes

@jevgenijusmarinuskinas jevgenijusmarinuskinas jevgenijusmarinuskinas approved these changes

@Martynienas Martynienas Awaiting requested review from Martynienas

@JelenaRy JelenaRy Awaiting requested review from JelenaRy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestas-zekas @vaidasmaciulis @jevgenijusmarinuskinas