Fixes for code review comments. Updated eslint configuration.

.eslintrc.js

@@ -43,6 +43,10 @@ module.exports = {
         "space-before-blocks": [
             "error",
             "always"
-        ]
+        ],
+		"space-infix-ops": [
+		    "error", 
+			{ "int32Hint": false }
+		]
     }
 };

example/tests/helpers.test.js

@@ -86,23 +86,26 @@ describe("Helpers", () => {
         expect(newPage._timeoutSettings.timeout()).toEqual(config.defaultTimeout);
     });
 
-    it("should generate random text without numbers", async () => {
+    it("should generate random text with no characters specified", async () => {
         //Arrange, Act
-        const text = await Helpers.generateRandomText(8, false);
-        const regex = /[^A-Za-z]/;
+        const text = await Helpers.generateRandomText(10);
+        const regex = /^[A-Za-z0-9]+$/;
 
         //Assert
-        expect(regex.test(text)).toBeFalsy();
-        expect(text.length).toEqual(8);
+        expect(regex.test(text)).toBeTruthy();
+        expect(text.length).toEqual(10);
     });
 
-    it("should generate random text with numbers", async () => {
-        //Arrange, Act
-        const text = await Helpers.generateRandomText(10, true);
-        const regex = /[^A-Za-z0-9]/;
+    it("should generate random text with custom characters list", async () => {
+        //Arrange
+        const chars = "0123456789";
+        const regex = /^[0-9]+$/;
 
+        //Act
+        const text = await Helpers.generateRandomText(8, chars);
+
         //Assert
-        expect(regex.test(text)).toBeFalsy();
-        expect(text.length).toEqual(10);
+        expect(regex.test(text)).toBeTruthy();
+        expect(text.length).toEqual(8);
     });
 });

framework/helpers.js

@@ -3,6 +3,7 @@ const fs = require("fs");
 const retry = require("async-retry");
 const config = require(process.cwd() + "/framework.config");
 const defaultTimeout = config.defaultTimeout;
+const defaultCharacters = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
 
 class Helpers {
     async takeScreenshot(filename) {
@@ -28,8 +29,7 @@ class Helpers {
 
     async goToUrlAndLoad(url, timeout = defaultTimeout) {
         await page.goto(url, {
-            waitUntil: "networkidle0",
-            timeout: timeout,
+            waitUntil: "networkidle0", timeout: timeout,
         });
     }
 
@@ -40,23 +40,19 @@ class Helpers {
     }
 
     async pageSetup(page) {
-        const environment = require(process.cwd() +
-            "/test-environment/environment.js");
+        const environment = require(process.cwd() + "/test-environment/environment.js");
         await environment.prototype.pageSetup(page);
     }
 
-    async generateRandomText(length, withNumbers) {
+    async generateRandomText(length, characters = defaultCharacters) {
         var result = "";
-        var characters = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
-        if (withNumbers) {
-            characters += "0123456789";
-        }
         var charactersLength = characters.length;
         for (var i = 0; i < length; i++) {
             result += characters.charAt(
                 Math.floor(Math.random() * charactersLength)
             );
         }
+        console.log(`Generated a random text: ${result}`);
         return result;
     }
 }