Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow core dumps to be piped into a program with an absolute path. #121

Merged
merged 1 commit into from Jul 19, 2019
Merged

Allow core dumps to be piped into a program with an absolute path. #121

merged 1 commit into from Jul 19, 2019

Conversation

samjmarshall
Copy link

Since Linux 3.6, if /proc/sys/fs/suid_dumpable is set to 2 ("suidsafe"), the pattern must be either an absolute path or a pipe.

Ensures the pipe pattern meets the requirements of kernel 2.6.19 (pipe immediately followed by an absolute path).

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samjmarshall thank you!

@artem-sidorenko
Copy link
Member

@samjmarshall can you maybe make the DCO checker happy?

@samjmarshall
Copy link
Author

All sorted. DCO checker is happy :)

@artem-sidorenko
Copy link
Member

I tested it with some regexp pattern evaluator and checked the docs - it looks good for me!
@atomic111 @mcgege @chris-rock @rndmh3ro can somebody please have a look and cross-check this?

Copy link
Member

@mcgege mcgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me too

@artem-sidorenko artem-sidorenko merged commit 74df8a2 into dev-sec:master Jul 19, 2019
@artem-sidorenko
Copy link
Member

@mcgege @samjmarshall thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants