This repository has been archived by the owner on Apr 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
massongit
commented
Nov 15, 2022
@@ -125,7 +125,8 @@ export class CdkStack extends Stack { | |||
const oidcAud = 'sts.amazonaws.com' | |||
const provider = new iam.OpenIdConnectProvider(this, 'OIDCProvider-github', { | |||
url: 'https://token.actions.githubusercontent.com', | |||
clientIds: [oidcAud] | |||
clientIds: [oidcAud], | |||
thumbprints: ['6938FD4D98BAB03FAADB97B34396831E3780AEA1'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goryudyuma
approved these changes
Nov 18, 2022
インフラの差分
|
massongit
added a commit
that referenced
this pull request
Nov 18, 2022
This reverts commit a869f2b.
massongit
added a commit
that referenced
this pull request
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-cdk#8607
GitHub ActionsからOIDC経由でAWSにアクセスできなくなっているので、OIDCプロバイダーにthumbprintsを明示的に指定します。
CIから
cdk diff
やcdk deploy
が実行できないので、approveをもらったら手元でcdk deploy
を実行し、CIを再実行してマージする予定です。[手元でのcdk diff]