fix: improve ipynb loading hitches #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes three issues that happen when loading an ipynb file in the code editor: 1) when an ipynb file was selected and the file content wasn't loaded, the error handler was called 2) when a parse error occurred, the error handler was called with incorrect arguments 3) when loading an ipynb file, the unparsed file content renders to the page briefly even when the content is valid We also update the loadable usage in the codeeditor to use the loadable class.
✅ Deploy Preview for hew-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 49 49
Lines 6482 6482
Branches 454 454
=======================================
Hits 5366 5366
Misses 1116 1116 ☔ View full report in Codecov by Sentry. |
EmilyBonar
approved these changes
Aug 21, 2024
|
good point -- i think it's useful to represent the result as an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes three issues that happen when loading an ipynb file in the code editor:
when an ipynb file was selected and the file content wasn't loaded, the error handler was called.
when a parse error occurred, the error handler was called with incorrect arguments.
when loading an ipynb file, the unparsed file content renders to the page briefly, even when the content is valid.
We also update the loadable usage in the codeeditor to use the loadable class methods and prevent the filename info from shrinking and growing during the file loading process.