-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Workspace Models tests [CM-538] #9998
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
selector: '[id="modelDescription"]', | ||
}); | ||
readonly addMoreDetails = new BaseComponent({ | ||
parent: this, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.body
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as well as the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly im just excited to see all my work being expanded upon. thanks for the contributions, very nice pace as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9998 +/- ##
==========================================
- Coverage 54.53% 50.47% -4.06%
==========================================
Files 1257 948 -309
Lines 156933 128347 -28586
Branches 3614 3614
==========================================
- Hits 85587 64787 -20800
+ Misses 71213 63427 -7786
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example for unit tests!
Do we think it's possible to auto generate boiler plate code such as ModelCreateModal
Ticket
CM-538
Description
Adds automated e2e tests for "Workspace Models" section of Workspaces/Projects release party test plan
https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1321238531/Workspaces+Projects
Test Plan
No additional testing required, automated tests should pass.
Checklist
docs/release-notes/
See Release Note for details.