fix: fix default id search for runs #9988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an issue where the default search field for global run id would not work properly when interacting with the filter form. the issue is compound: 1) we defaulted new form fields to the `id` column of the experiment location, so when searching runs the column was invalid 2) the form select uses the column name to determine what copy to show in the select label, so the copy looked like it was using the global run id column when it wasn't. we fix this by specifying the location of all new children in the form field.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9988 +/- ##
==========================================
- Coverage 54.53% 50.47% -4.06%
==========================================
Files 1257 948 -309
Lines 156935 128353 -28582
Branches 3614 3615 +1
==========================================
- Hits 85578 64785 -20793
+ Misses 71224 63435 -7789
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashtonG
added
the
to-cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit e92c474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-811
Description
this fixes an issue where the default search field for global run id would not work properly when interacting with the filter form. the issue is compound:
we defaulted new form fields to the
idcolumn of the experiment location, so when searching runs the column was invalidthe form select uses the column name to determine what copy to show in the select label, so the copy looked like it was using the global run id column when it wasn't.
we fix this by specifying the location of all new children in the form field.
Test Plan
on the runs page, open the filters view and reset the view by hitting "clear filters".
the filter view should have closed. open it back up and update the filter value to match a run id that's currently in the view
the run should show up.
Checklist
docs/release-notes/See Release Note for details.