Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deactivate User test flake #9974

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Sep 24, 2024

Ticket

Description

Potential fix for flaky "Deactivate and Reactive" test.

Not reproducing failures locally, doesn't seem like this would need to be handled differently for CI. Attempting to add some assertions that are used in the similar "Bad Credentials" test, which is not flaky on CI, to see if that addresses the issue.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner September 24, 2024 14:44
@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f3ca079
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66f2d063892ad700082d425a
😎 Deploy Preview https://deploy-preview-9974--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.44%. Comparing base (924f663) to head (f3ca079).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9974      +/-   ##
==========================================
- Coverage   54.51%   50.44%   -4.08%     
==========================================
  Files        1256      947     -309     
  Lines      156700   128106   -28594     
  Branches     3603     3603              
==========================================
- Hits        85424    64622   -20802     
+ Misses      71143    63351    -7792     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

@johnkim-det johnkim-det merged commit d02495b into main Sep 24, 2024
87 of 99 checks passed
@johnkim-det johnkim-det deleted the deactivate-user-test-flake branch September 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants