ci: fix flaky test_allocation_csv tests #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_cmd_capture was flaking around maybe 1% of the time. I can't tell if the failure was that timestamp_before is non-inclusive or if was just a rounding error somewhere, but adding only a couple seconds to the boundaries seems to be enough to avoid flakes. I fixed the other tests in the file too. One test had been patched already... but not the others.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9953 +/- ##
=======================================
Coverage 54.50% 54.50%
=======================================
Files 1253 1253
Lines 156630 156630
Branches 3599 3600 +1
=======================================
Hits 85368 85368
Misses 71129 71129
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
azhou-determined
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_cmd_capture was flaking around maybe 1% of the time.
I can't tell if the failure was that timestamp_before is non-inclusive or if was just a rounding error somewhere, but adding only a couple seconds to the boundaries seems to be enough to avoid flakes.
I fixed the other tests in the file too. One test had been patched already... but not the others.
Example flake.