Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GET global config policies API #9952

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Sep 17, 2024

Ticket

Description

Added GET global config policies API endpoint

Test Plan

Added automated test

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6b04939
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66eb489cd810780008495274

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (88a4c67) to head (6b04939).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/api_config_policies.go 25.00% 18 Missing ⚠️
...ternal/configpolicy/postgres_task_config_policy.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9952      +/-   ##
==========================================
- Coverage   54.52%   54.51%   -0.02%     
==========================================
  Files        1252     1252              
  Lines      156688   156704      +16     
  Branches     3600     3600              
==========================================
- Hits        85435    85423      -12     
- Misses      71120    71148      +28     
  Partials      133      133              
Flag Coverage Δ
backend 45.18% <23.07%> (-0.04%) ⬇️
harness 72.75% <ø> (ø)
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ternal/configpolicy/postgres_task_config_policy.go 89.28% <0.00%> (-3.31%) ⬇️
master/internal/api_config_policies.go 47.78% <25.00%> (-13.83%) ⬇️

... and 3 files with indirect coverage changes

@salonig23 salonig23 marked this pull request as ready for review September 17, 2024 23:07
@salonig23 salonig23 requested a review from a team as a code owner September 17, 2024 23:07
@salonig23 salonig23 requested review from maxrussell and kkunapuli and removed request for maxrussell September 17, 2024 23:07
Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the refactor with GetConfigPolicies.

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Left a few comments 🎉

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work Saloni!

@salonig23 salonig23 merged commit 95f079d into main Sep 18, 2024
81 of 94 checks passed
@salonig23 salonig23 deleted the add-global-get-config-policy-api branch September 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants