-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GET global config policies API #9952
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9952 +/- ##
==========================================
- Coverage 54.52% 54.51% -0.02%
==========================================
Files 1252 1252
Lines 156688 156704 +16
Branches 3600 3600
==========================================
- Hits 85435 85423 -12
- Misses 71120 71148 +28
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the refactor with GetConfigPolicies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Left a few comments 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work Saloni!
Ticket
Description
Added GET global config policies API endpoint
Test Plan
Added automated test
Checklist
docs/release-notes/
See Release Note for details.