Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change log level for log retention policies #9935

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Sep 16, 2024

Ticket

CM-528

Description

Change log level of log retention policy logs to "Info" level, not "trace".

INFO[2024-09-16T10:36:29-06:00] deleting expired task logs                    component=log-retention default-retention-days=-1
INFO[2024-09-16T10:36:29-06:00] deleted expired task logs                     component=log-retention err="<nil>" rows=123

Test Plan

N/A.
Spin up on your own test cluster to verify, set master config values for log retention policy/days. Then, clean up with det task cleanup-logs. You should see these log levels in the Info level.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 16, 2024
@carolinaecalderon carolinaecalderon marked this pull request as ready for review September 16, 2024 16:21
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner September 16, 2024 16:21
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 229229e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e85b17d5761c00081f3b1f
😎 Deploy Preview https://deploy-preview-9935--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (867eb31) to head (229229e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9935   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files         751      751           
  Lines      104462   104462           
  Branches     3598     3597    -1     
=======================================
  Hits        61824    61824           
  Misses      42506    42506           
  Partials      132      132           
Flag Coverage Δ
backend 43.80% <ø> (ø)
harness 72.75% <ø> (ø)
web 54.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@carolinaecalderon carolinaecalderon merged commit 0928958 into main Sep 16, 2024
82 of 97 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/cm-528 branch September 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants