Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetTrialRemainingLogRetentionDays should take global log retention days into account [CM-518] #9914

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Sep 10, 2024

Ticket

CM-518

Description

GetTrialRemainingLogRetentionDays was not taking global log retention days into account while calculating remaining days. Fixed it by adding a check and an automated test for this scenario.

Test Plan

Added automated test.
For manual testing:

  1. Add a global log retention policy to master config:
 retention_policy:
         log_retention_days: 90
         schedule: 0 3 * * *
  1. Start devcluster.
  2. Create an experiment and do not specify the log retention days.
  3. After a trial under the experiment is completed, the remaining log retention days on the Logs tabs of the trial overview shows accurate value (89 days)
Screen Shot 2024-09-10 at 3 42 07 PM

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.24%. Comparing base (8fb9f6b) to head (d156c93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9914   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files         750      750           
  Lines      104341   104341           
  Branches     3597     3597           
=======================================
  Hits        61812    61812           
  Misses      42398    42398           
  Partials      131      131           
Flag Coverage Δ
backend 43.80% <ø> (ø)
harness 72.75% <ø> (ø)
web 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d156c93
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e0cb59280eb40008662cbe
😎 Deploy Preview https://deploy-preview-9914--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salonig23 salonig23 marked this pull request as ready for review September 10, 2024 22:43
@salonig23 salonig23 requested a review from a team as a code owner September 10, 2024 22:43
@salonig23 salonig23 requested review from maxrussell and corban-beaird and removed request for maxrussell September 10, 2024 22:43
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salonig23 salonig23 merged commit c877383 into main Sep 10, 2024
87 of 101 checks passed
@salonig23 salonig23 deleted the fix-remaining-retention-days branch September 10, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants