Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add workspace tests #9905

Merged
merged 14 commits into from
Sep 11, 2024
Merged

test: add workspace tests #9905

merged 14 commits into from
Sep 11, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Sep 9, 2024

Ticket

CM-466

Description

Adds e2e tests to cover filtering, sorting, and toggling the view on the Workspaces page. Also fixes some existing edge case issues (using correct user to create workspaces, testId for empty message components).

Test Plan

No additional release party testing required. Automated tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f67ca1a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e0b8adc45b34000891a89d
😎 Deploy Preview https://deploy-preview-9905--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 50.55%. Comparing base (c1499ac) to head (f67ca1a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/components/GridListRadioGroup.tsx 0.00% 11 Missing ⚠️
webui/react/src/pages/WorkspaceList.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9905      +/-   ##
==========================================
- Coverage   54.57%   50.55%   -4.03%     
==========================================
  Files        1250      938     -312     
  Lines      156266   127310   -28956     
  Branches     3598     3597       -1     
==========================================
- Hits        85283    64359   -20924     
+ Misses      70852    62820    -8032     
  Partials      131      131              
Flag Coverage Δ
harness ?
web 54.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/pages/WorkspaceList.tsx 0.00% <0.00%> (ø)
webui/react/src/components/GridListRadioGroup.tsx 0.00% <0.00%> (ø)

... and 333 files with indirect coverage changes

Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about test selectors convention... LGTM

webui/react/src/e2e/models/pages/WorkspaceList.ts Outdated Show resolved Hide resolved
@johnkim-det johnkim-det merged commit 03961b5 into main Sep 11, 2024
82 of 94 checks passed
@johnkim-det johnkim-det deleted the CM-466 branch September 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants