-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add workspace tests #9905
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9905 +/- ##
==========================================
- Coverage 54.57% 50.55% -4.03%
==========================================
Files 1250 938 -312
Lines 156266 127310 -28956
Branches 3598 3597 -1
==========================================
- Hits 85283 64359 -20924
+ Misses 70852 62820 -8032
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment about test selectors convention... LGTM
Ticket
CM-466
Description
Adds e2e tests to cover filtering, sorting, and toggling the view on the Workspaces page. Also fixes some existing edge case issues (using correct user to create workspaces, testId for empty message components).
Test Plan
No additional release party testing required. Automated tests should pass.
Checklist
docs/release-notes/
See Release Note for details.