Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused languages from code editor #9898

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Sep 5, 2024

Ticket

ET-751

Description

This updates the hew package, which has been updated to reduce the number of available code editor languages to just javascript, yaml, json and markdown. this should shrink the package size by 2MB unpacked, 500KB packed.

Test Plan

React build size should be smaller. otherwise no testing is required

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@ashtonG ashtonG requested a review from a team as a code owner September 5, 2024 19:19
@cla-bot cla-bot bot added the cla-signed label Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 800b4db
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e86c7b361bf90008e1e4c8
😎 Deploy Preview https://deploy-preview-9898--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashtonG ashtonG requested review from thiagodallacqua-hpe and removed request for julian-determined-ai September 5, 2024 19:19
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.45%. Comparing base (0928958) to head (800b4db).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9898      +/-   ##
==========================================
- Coverage   54.52%   50.45%   -4.08%     
==========================================
  Files        1252      943     -309     
  Lines      156557   127962   -28595     
  Branches     3600     3599       -1     
==========================================
- Hits        85363    64560   -20803     
+ Misses      71062    63270    -7792     
  Partials      132      132              
Flag Coverage Δ
harness ?
web 54.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

@ashtonG
Copy link
Contributor Author

ashtonG commented Sep 6, 2024

for posterity
before
image

after
image

@ashtonG ashtonG merged commit 02e302f into main Sep 17, 2024
83 of 95 checks passed
@ashtonG ashtonG deleted the bug/unused-hew-languages branch September 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants