chore: add unmarshal functions for task config policies #9896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
kkunapuli
commented
Sep 5, 2024
| func MarshalConfigPolicy(configPolicy interface{}) *structpb.Struct { | ||
| return protoutils.ToStruct(configPolicy) | ||
|
|
||
| } |
There was a problem hiding this comment.
I like the symmetry of having a function defined for discoverability, but it's not adding any new functionality.
kkunapuli
commented
Sep 5, 2024
| return false | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Using the workload type defined in model instead and moving workload type validation to configpolicy.utils.
kkunapuli
commented
Sep 5, 2024
| @@ -11,15 +11,14 @@ message PutWorkspaceConfigPoliciesRequest { | |||
| // The workspace the config policies apply to. Use global API for | |||
| // global config policies. | |||
| int32 workspace_id = 1; | |||
| // Specifies which workload type the config policies apply to: EXPERIMENT or | |||
| // NTSC. | |||
| // The workload type the config policies apply to: EXPERIMENT or NTSC. | |||
There was a problem hiding this comment.
I noticed I had missed some spots when fixing descriptions in #9880. Fixing it now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9896 +/- ##
==========================================
- Coverage 54.80% 54.68% -0.13%
==========================================
Files 1237 1264 +27
Lines 154974 156878 +1904
Branches 3597 3597
==========================================
+ Hits 84938 85790 +852
- Misses 69905 70957 +1052
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kkunapuli
requested review from
carolinaecalderon and
salonig23
and removed request for
carolinaecalderon
salonig23
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-502
Description
Introduce unmarshal functions to process user input for task config policies.
Test Plan
Covered by unit tests.
Checklist
docs/release-notes/See Release Note for details.