Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hf callback metric naming #9887

Merged
merged 5 commits into from
Aug 31, 2024
Merged

fix: Hf callback metric naming #9887

merged 5 commits into from
Aug 31, 2024

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Aug 30, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/MD-511

Description

TRAIN = "train_progress" appears to be a confusing variable name for a value that is intended as a placeholder. This caused an issue in the behavior of on_log(). This PR renames TRAIN to DEFAULT and TRAIN_PROGRESS to TRAIN

Test Plan

Run an example with huggingface callback and make sure metrics are being recorded properly.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2024
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6d010a3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66d25c5fa11bbb0008c1191c

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.43%. Comparing base (d54713c) to head (6d010a3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9887      +/-   ##
==========================================
- Coverage   54.69%   50.43%   -4.27%     
==========================================
  Files        1261     1106     -155     
  Lines      156700   144542   -12158     
  Branches     3597     3597              
==========================================
- Hits        85708    72898   -12810     
- Misses      70861    71513     +652     
  Partials      131      131              
Flag Coverage Δ
harness 49.46% <ø> (-23.16%) ⬇️
web 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 245 files with indirect coverage changes

@MikhailKardash MikhailKardash marked this pull request as ready for review August 30, 2024 22:16
@MikhailKardash MikhailKardash requested a review from a team as a code owner August 30, 2024 22:16
@MikhailKardash MikhailKardash force-pushed the hf_callback_actual_fix branch from 5a34ff6 to f635d2f Compare August 30, 2024 23:15
@MikhailKardash MikhailKardash merged commit 590c362 into main Aug 31, 2024
41 of 80 checks passed
@MikhailKardash MikhailKardash deleted the hf_callback_actual_fix branch August 31, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants