Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent hyperparameter search modal submitting the same request multiple times #9883

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Aug 29, 2024

Ticket

ET-119

Description

Disable “Run Experiment” button when clicked once and still running submitExperiment

Test Plan

  • Check if “Run Experiment” button is disabled and loading in hyperparameter search modal when clicked once and still running submitExperiment, so user cannot submit the same hyperparameter search multiple times.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2024
@keita-determined keita-determined marked this pull request as ready for review August 29, 2024 22:05
@keita-determined keita-determined requested a review from a team as a code owner August 29, 2024 22:05
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 661286f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66d0f08ada051f0008e7576d
😎 Deploy Preview https://deploy-preview-9883--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined changed the title fix: prevent multiple submits in hyperparameter modal fix: prevent multiple submits in hyperparameter search modal Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (ad5fe5a) to head (661286f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9883      +/-   ##
==========================================
- Coverage   54.69%   50.56%   -4.14%     
==========================================
  Files        1261      938     -323     
  Lines      156699   127323   -29376     
  Branches     3596     3596              
==========================================
- Hits        85712    64378   -21334     
+ Misses      70856    62814    -8042     
  Partials      131      131              
Flag Coverage Δ
harness ?
web 54.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...react/src/components/HyperparameterSearchModal.tsx 90.52% <100.00%> (ø)

... and 323 files with indirect coverage changes

@keita-determined keita-determined changed the title fix: prevent multiple submits in hyperparameter search modal fix: prevent hyperparameter search modal submitting the same request multiple times Aug 29, 2024
@keita-determined keita-determined changed the title fix: prevent hyperparameter search modal submitting the same request multiple times fix: prevent hyperparameter search modal submitting the same request multiple times Aug 29, 2024
Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@keita-determined keita-determined merged commit b1c0814 into main Aug 30, 2024
91 of 104 checks passed
@keita-determined keita-determined deleted the fix/prevent-multiple-submit branch August 30, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants