fix: sorting by arbitrary metadata #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9874 +/- ##
==========================================
- Coverage 54.75% 54.75% -0.01%
==========================================
Files 1261 1261
Lines 156346 156356 +10
Branches 3598 3599 +1
==========================================
+ Hits 85608 85613 +5
- Misses 70607 70612 +5
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
August 28, 2024 11:08
jesse-amano-hpe
approved these changes
Aug 28, 2024
|
|
||
| require.NoError(t, err) | ||
| require.Equal(t, int32(exp2.ID), resp.Runs[0].Experiment.Id) | ||
| require.Equal(t, int32(exp.ID), resp.Runs[1].Experiment.Id) |
There was a problem hiding this comment.
nit: this test would probably benefit from parameterization / "table-driven" design. But, it does what we need it to, and I've run it a few times locally with different inputs/expectations, and it's good as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-748
Description
Add sorting for arbitrary metadata
Test Plan
Go to run table and select a metadata column and sort
Checklist
docs/release-notes/See Release Note for details.