-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rbac for config policies #9873
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9873 +/- ##
==========================================
- Coverage 54.71% 54.68% -0.03%
==========================================
Files 1261 1261
Lines 156756 156810 +54
Branches 3597 3597
==========================================
- Hits 85770 85755 -15
- Misses 70855 70924 +69
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
return (&MiscAuthZBasic{}).CanModifyGlobalConfigPolicies(ctx, curUser) | ||
} | ||
|
||
// CanViewGlobalConfigPolicies calls the RBAC implementation but always allows access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for my own knowledge - why do we have a function for viewing the policies if access is always allowed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my understanding, if we want to change who has those permissions it will be easier in the future, or if we want to add a feature to allow the admin to configure which user has which permissions, it would be easier if we already check this permission in the API handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks like an rbac test may be failing? Not sure if it's related or not.
e1dd803
to
60d7bc9
Compare
60d7bc9
to
e0b2b40
Compare
Ticket
CM-420
Description
Add RBAC permissions for modify and view config policies at the global and workspace levels.
Test Plan
CI passes
Checklist
docs/release-notes/
See Release Note for details.