Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove CSS rule for hiding the Form.Item error message #9872

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Aug 27, 2024

Ticket

ET-70

Description

There's a bug where, when you try to submit a form with errors, the error feedback messages won't show bellow the form items.

This PR intends to fix that.

Test Plan

  • Open a modal with a form.
  • try submitting with an error (like not filling a required field)
  • the message should appear bellow the form item.

Screenshot 2024-08-27 at 17 10 20

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 56a71a0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ec9675013e540008833f37
😎 Deploy Preview https://deploy-preview-9872--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.42%. Comparing base (eb1b0de) to head (56a71a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9872      +/-   ##
==========================================
- Coverage   54.49%   50.42%   -4.08%     
==========================================
  Files        1255      946     -309     
  Lines      156729   128135   -28594     
  Branches     3601     3600       -1     
==========================================
- Hits        85413    64611   -20802     
+ Misses      71183    63391    -7792     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found layout issues

@thiagodallacqua-hpe thiagodallacqua-hpe merged commit 43556e9 into main Sep 20, 2024
89 of 101 checks passed
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-70 branch September 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants