-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove CSS rule for hiding the Form.Item error message #9872
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9872 +/- ##
==========================================
- Coverage 54.49% 50.42% -4.08%
==========================================
Files 1255 946 -309
Lines 156729 128135 -28594
Branches 3601 3600 -1
==========================================
- Hits 85413 64611 -20802
+ Misses 71183 63391 -7792
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found layout issues
b963c7a
to
881a118
Compare
94c0063
to
14c6d62
Compare
webui/react/src/components/HyperparameterSearchModal.module.scss
Outdated
Show resolved
Hide resolved
9180375
to
aca404a
Compare
f1edc47
to
37cf1f5
Compare
37cf1f5
to
60bac7b
Compare
8ada5f9
to
59a5536
Compare
webui/react/src/components/HyperparameterSearchModal.module.scss
Outdated
Show resolved
Hide resolved
59a5536
to
1e83bd2
Compare
8c057de
to
81a62a9
Compare
81a62a9
to
7a6161a
Compare
Co-authored-by: Ashton G. <[email protected]>
Ticket
ET-70
Description
There's a bug where, when you try to submit a form with errors, the error feedback messages won't show bellow the form items.
This PR intends to fix that.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.