-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logic of different modes for webhook #9865
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9865 +/- ##
==========================================
- Coverage 54.65% 54.65% -0.01%
==========================================
Files 1261 1261
Lines 156226 156305 +79
Branches 3592 3591 -1
==========================================
+ Hits 85382 85424 +42
- Misses 70712 70749 +37
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Only need a spot check we get the default / slack responses. | ||
# Further tested in integrations. | ||
assert "TASK_LOG" in responses[default_path] | ||
assert "This log matched the regex" in responses[slack_path] | ||
assert "TASK_LOG" in responses[default_path] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a duplicate line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe specific_path
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Love the detailed test cases, good job!
Support workload alerting, different webhook modes, e.g., #9865
Support workload alerting, different webhook modes, e.g., #9865
Support workload alerting, different webhook modes, e.g., #9865
Support workload alerting, different webhook modes, e.g., #9865
Ticket
MD-479
Description
Part of workload alerting project.
ERD link: https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1666809868/Workload+Alerting+ERD
Expand the experiment config -> integrations -> webhooks
Below is a table for which group of experiments can trigger which mode of webhooks.
Test Plan
Unit tests and e2e tests should be able to cover it.
To test from WebUI:
Checklist
docs/release-notes/
See Release Note for details.